CVS log for epic5/KNOWNBUGS

Request diff between arbitrary revisions

* Add $serverctl(READ_FILE filename) to add servers from a servers file.
* Add some preliminary code for sending a /msg to a logfile.
* Make scrollback_start/end use "scroll up/down 999,999 lines"
* This is for future consolidation of the scrollback code.

* Redirect $stdout in ruby back to EPIC.echo so ruby warnings display properly
* This is to fix howl's bug: /ruby {EPIC.echo EPIC.expr "S"}

New epic!
* Release EPIC5-0.3.9 (Contumacy) (commit 1554)

* Add support for /ignore'ing a server (for undernet)
* Add --without-wserv flag to configure (see UPDATES)
* Add checks in configure for posix-like job control
* Add support so no job control -> no wserv support.

* Fix make_window_current() to use the main_screen if all else fails.

* Support /ignore nick|#chan ACTION

xecho's -all option clobbered the first word after it as if it took params

* Fix hitting ^C twice so it sends SIGUR2 instead of SIGLARLM
* This is because we don't use alarm() any more, and ^C^C stops infinite loop
* Fix some compiler nits that larne found on strict compilers.

Revamped input line a little. Added indicator for text scrolled off the left
of our input line.

Added /on. /ON WINDOW_NOTIFED.

Fix signal handling for SIG_IGN and SIG_DFL so SIGPIPE doesn't cause crash.

New epic!

Fix a NULL deref for a rather unreasonable situation.

* Phase two of larne's patch is to isolate features that require job control
* You can #define NO_JOB_CONTROL to turn off fork/exec type stuff.
* Soon, the configure script will auto-grok this.

* Roll in a bunch of changes from larne to make epic5 more vms-friendly
* Rename if.h -> ifcmd.h  (larne) -- Make sure you rerun configure!
* Run make depend to pick up name change of if.h
* Check for <sys/param.h> in configure (larne)
* Extern funcs are case insensitive in strict c90, fix (larne)
* Rename options -> options.h since vms requires a dot in filename (larne)
* Change "readonly" -> "rdonly" since "readonly" is a symbol in vms. (larne)
* Pull in "compat.h" for gailib.c and glob.c (larne)
* Set stdout to be explciitly line buffered at startup (larne)
* Returning a value from void functino forbidden by strict c90. fix (larne)
* Fix some compiler warnings that were lying around.
* There are more changes forthcoming, these were the easy ones.

* Roll forward portability changes from epic4-2.10 (larne)
* This also includes term.h -> termx.h -- Make sure you rerun configure!

Roll in all changes larne has requested for his porting effort,
including all the stuff already pushed into epic4.

* Fixed an apparent typo in getnrolitems in data_array.
* Fixed a bug in autoget where it wasn't actually starting a download.
* Fixed yet another bug in commandqueues involving double quote dequoting.
* This covers for an apparent bug in $shift() which should automatically
  dequote quotes (unfixed).
* Added USER1 - USER10, OPERWALL and SYSERR levels to the ignore system.
* Added ":" hack to /notify as per UPDATES.

* $write(w-1 ....) is documented to write to the global logfile and now does.
* Fixed a long standing notify bug where only one ISON would be sent.

* Add /on signal (pegasus)
* Fix build on interix (twincest)
* Fix compile warnings and a c99-ism
* Fix another panic() causable by /echo. ugh.

* Fixed q1cmd in command queues to address space mangling issues
  first noticed by Kraca.
* Fixed data_struct to work with dword.
* Fixed tabkey.ce to work better with args with spaces in them.
* Fixed tabkey.ce to not put / prefix on recursed commands (again).
* Fixed tabkey.ce to work with 005 CHANTYPES.
* Fixed $xdebug() to work with multiple arguments as it once did.
* Fixed what appears to be a typo in elf.c and I don't really know what
  it does.  I hope it doesn't break anything for anybody.  XXX
* Minor optimisation for notify.c.
* Added handling of the 340 numeric in numbers.c
* Handle extraneous spaces in server MODE messages.  Austhex adds these.
* Trigger waiting ISON's when we connect again.  I don't recall why
  I took this out in the first place.
* Added "/userhost -flush", which will flush the queue of messages waiting
  to be sent, NOT the queue awaiting replies.
* Extended "/ison -f" to also flush the queue of ISON's waiting to be sent.

Fix all the compile warnings that I let go way too long.

* Put 'sig.inc' in include rather than source to fix build for r/o srcdir
* #undef strtoimax() if we are going to define our own to fix build
* Fix printf() qualification for syserr()
* Fix $write(@W<num> ...) so uppercase W works
* Nix strip_control() which isn't used any more.
* Make #define WINDOW_CREATE go away -- it's now mandatory.
* Reorganize do_screens() in prep for future work

Emergency fix.

New epic! (epic5-0.3.6)

Add $2 as the /window command in /on window_command

* Fix new math parser comparison operators to work properly with numbers.
* Add function $check_code(), looks for unmatched parens or braces in string.

* Make /xecho -w -1 go to the current window, for compat with epic4 (rb Black)
* Make the /server list show the vhost you're using.
* /LOADing an executable file results in a warning and not an error.
* Fix input line so it doesn't display hidden contents after ^L (rb wjr)
* Add a $strptime() function, but I still need a strptime() compat version.
* Add $ignorectl(SUSPEND) and $ignorectl(UNSUSPEND) to turn off ignores.

* Add a new internal function prepare_display2() a reduced version of p_d().
* Add a new internal function fix_string_width(), the guts of $fix_string()
* Fix /set indent to use prepare_display2(). Now you can use ^C codes. yay!
* Fix fd leak if fork() fails for /exec.
* Fix window toplines so they extend the width of the screen like statusbars.

Fix $write(w3 blah) crash reported by ce.

* $info(o) now includes 'r' for libarchive, and 'x' for iconv support
* Unconditinally unset GREP_OPTIONS in configure (rb Pegasus)
* Fix /oper password being shown because term_echo() not called. (rb wjr)
* Properly handle multiple spaces between protocol tokens (rb Krisp)
* Fix crash with standard_warning_level() when you do /window level nonsense.
* Support /input "prompt" (args) {code}. See UPDATES. (rb kreca) (fusion)

Fix build

Fix build (rb zlonix)

* Change builtins script so it doesn't /xecho -w for who replies.
* Fix typos in dcc_ports
* New version of tabkey.ce from fudd.
* Make /dcc list output go to level OTHER by special request of kreca.

* Everything below is from fusion (Alexander Grotewohl)
* If libarchive is present, support zip/tar files in /load and $open()
* Create a new "epic load file" data type that wraps FILE or libarchive.
* Extend uzfopen() to use the new "epic load file" data type.
* Extend the loader to honor the new "epic load file" data type
* Extend $open() [read only for now] to honor the epic load file data type
* Not all operations are supported on zip files.
* Add new function $fix_width() returns string with a guaranteed printable len
* End of things contributed by fusion (Alexander Grotewohl)

* New version of /load dump from black.

* Add /lastlog -window for fusion.

* Change /on listings so they tell you if a hook is "disabled".
* Add forgotten code to move lastlog items between windows for /window number
* Fix bug where default numeric output wouldn't go to a channel's window.
* Remove a superfluous message_from() when parsing server stuff.

From KNOWNBUGS:
* Updated $shift() and $pop() with multiple args to work with dword but left it
  #ifdef'd out as per UDPATES.  Also updated regress/funcs to test these.
* Added current package to end of $loadinfo().
* Changed /reconnect to jump to the next server in the address list if possible.
* If epic crashes and /xdebug crash is set, sleep and wait for a debugger.

Most of these should probably be commented on in UPDATES.

From KNOWNBUGS:
* Fixed builtins to not return spaces at end of $xform() functions (last commit).
* Fixed commented out lines in commandqueues for backward compatibility.
* FINALLY cleaned up code in data_array.
* Added some /assign handling functions to data_struct.
* Fixed $chhops(), $nochhops(), $chvoices() $chnovoices() in script/functions.
* Changed tabkey.ce to _also_ complete from notify list by default.
* Changed tabkey.ce to complete recursed commands without a leading slash.

* New versions of builtins, dump, and history from black

* Add a bunch of functions to move lastlog items between windows.
* No way for the user to use them yet (still thinking about it)
* Add $windowctl(NEW) and $windowctl(NEW_HIDE)...

* Refactor all lastlog stuff to use a global lastlog buffer.  Yay!
* Comment out per-window lastlog stuff

* Add a "rejects" variable to str_to_mask()
* Make str_to_mask() shut up.  Callers should handle error output
* Create a standard_level_warning() handler callers can use.
* Make the consumers of str_to_mask() handle their own error messages. yay!

* Create aliases for [url|b64][en|de]code, sedcrypt, and sha256 into builtins.
* Comment out builtin [url|b64][en|de]code, sedcrypt, sha256 builtin functions.
* Change /xquote -u to use xform() instead of urldecode().
* Change dcc_url[en|de]code to use xform() instead of urldecode().
* Change /on ssl_server_cert to use xform() isntead of urldecode().
* This allows me to comment out old urldcode/base64decode stuff. yay!

New epic!

* Add split_string() which converts a general delimited string to (char **)
* Add $splitw(delim string) which converts delimited string into a dword list
* Use $unsplit() to convert $splitw() into a uword list (see UPDATES)
* Fix ./configure --without-ipv6 to allow compiling on opensewer.

* Add new status expando %{1}H which expands when in hold mode and not holding.
* Add /set status_holdmode which controls %{1}H
* Add %{1}H to the default status format.

* Fix panic when you call :func() and there is a builtin, but no alias.

* The dot (".") and tilde ("~") are unreserved characters in rfc3986 (urlencode)

* Revert commit 1498 (the dcc stuff) -- it was half baked.
* Fix warnings found with --with-warns.

* Bugfix. $tobase(b i) now supports negative integers (i).

* Added function $is8bit(). Intended to be used to discover 8-bit characters.
  $is8bit() will return the index number of the first character with the eight
  bit set, or -1 if nothing is found.

Oops.  This file didn't get saved before the commit.

*** I'm only half done here!  Some stuff is probably broken! ***
-- Just please be patient when telling me what I broke and I'll fix it. --

* Begin a refactoring of dcc to make my life easier
* Simplify register_dcc_offer(), removing unnecessary args.
* Also, register_dcc_offer() will only take url-encoded filenames now.
* Fix up the ctcp handler do_ctcp to urlencode offered filenames.
* Change the DCC_FILE* macros to DCC_SEND and DCC_GET to stop confusing me
* Add a "offer_filename" variable to dcc's for next round of work
* GC some unused code
* Break dcc_message_transmit() into dcc_raw_transmit() and dcc_chat_transmit()
* Drastically simplify those two functions
* Fix up dcc_raw_transmit() so the hostname isn't required
* This means /dcc raw <fd> <host> <msg> ignores <host>. yay!

* Apparantly solaris 9 doesn't have <stdint.h>, intmax_t, or strtoimax. ick.
* Begin "fixing" protected implied hooks.  Must test above examples.
* The sequence we delete stuff on shutdown actually does matter.  (Fix crash)

* Commit a 'url.irc' script that I don't know where it came from...

* Fix missing NULL for $hookctl(list ...) [rb howl]
* Fix various other issues that valgrind found (yay!)

* Don't use NULL in configure; use 0 instead.

--- This is a bunch of stuff I've been sitting on while I wait for howl to
finish what he was doing. ---

* Add support for ./configure --localdir
* Add support for ./configure --with-iconv=/usr/local
* Add support for looking for iconv in configure in various places
* Make configure check for nanosleep().
* Add function decls for [sg]et_server_realname()
* New version of screen.e
* Change "filename" to "local_filename" in dcc's, in prep of further work.
* Un-revert a few minor things.

* Added $serverctl(get/set -1 realname/default_realname).
* $Y now is a synonym for $serverctl(get -1 realname).
* Added $xform(iconv fromcode/tocode ...) wrapper around iconv(3). With this
  epic5 takes babysteps towards supporting Unicode.

* Don't want to regfree() a failed attempt to regcomp(). (rb larne)

* Add /SET DEFAULT_REALNAME and DEFAULT_USERNAME
* Add scripted /set realname and /ircuser in builtins for backwards compat.

* Fix BACKWARD_WORD or PREVIOUS_WORD or whatever it's called.

* Fix configure so --with-threaded-stdout pulls in -pthread
* Include some commented out code that I'm ruminating over for input line
* Create CURSOR_LEFT and CURSOR_RIGHT macros to avoid assigning LOGICAL_CURSOR
* Default xforms now don't need to be ordered, or have default refnums.

Make $xform() support dynamic at runtime.  I'll be using this soon to
remove the #ifdef HAVE_SSL in ircaux.c

* Add /lastlog -rewrite (see UPDATES)
* Add /set lastlog_rewrite as a special favor for larne.

* Add $windowctl(GET refnum CHANNELS) for black.

* Fix hookctl(set list ... implied {...}) to work as intended (rb zlonix)

* Add new level SYSERR (see UPDATES)
* Add a server refnum to syserr() to send the syserr to the proper window.
* Add a server refnum to new_open() so we can pass it to syserr().
* Add new flag to /XECHO, /XECHO -AS (output to all windows on server)
* This should make syserrs go to the "correct window" most of the time (larne)

* Fix bug that kept implied on hooks from working (important fix!)

New epic!

* Fix infinite recursion if you load a script as a formats file.

* Fix it so it compiles without ssl support again.
* Add "ALL" $xform() encoder, returns all valid xforms

* Allow encryption $xform() handlers to reformat their keys, so we can...
* Add SHA256/AES/AESSHA $xform() encoders

* Fix happykey().  Sometimes, I just don't pay enough attention.
* Don't trim 1 too many chars on incoming encrypted messages. Important!
* Fix buffer sizes being too small to hold buffer for enc/dec short strings.
* Add $xform() handlers for blowfish and cast5
* Whip the $xform() callback functions into usable shape.
* Fix base64 encoding both via $xform() and $b64encode().
* Rewrite $xform(), see UPDATES.  Strong crypto now supported! YAY!

* Add the ** unary operator -- double expand.  See UPDATES
* Comment what I'm going to mangle xform into.

* Add a server param to what_channel() so i can use it in send_text() later.
* Add length of 'meta' arg to ciphers so 'meta' doesn't have to be c string

* Fix a couple of bugs rb zlonix
* When doing /stack pop set ... the callback (if any) should be invoked.

* Add mask_to_(positive|negative)_str to convert masks to shorter strings
* So now mask_to_str() returns strings like "ALL -DCC" if it's shorter!

* Add dccctl(DEFAULT_PORT <string>) [see UPDATES]
* Add /on dcc_lost case for cant-bind-port [see UPDATES]
* Add 'dcc_ports' script [see UPDATES]

* Change /say (or the empty command) to send to channel first, query second
* Add $dccctl(SET|GET ref WANT_PORT) to set the -p flag.
* Change tabkey.jm to use /msg -serv/nick instead of /msg serv:nick

* Add ^Vs to the start of  DEFAULT_STATUS_FORMAT* in config.h
* Comment out code for /set reverse_status_line pending removal later.
* GC the code for -f/-F/-o/-O command line arguments
* Fix the serverctl() comment for howl

* Fix crash for /parsekey type_text

* Add socks5p.h from epic4 so we can build with socks5 again.
* Remember, it's ./configure --with-socks5=/usr/local/lib
* Make update_input() take a screen as an argument, to update one screen only.
* Make /window create screen's input lines work again (rb kitambi)

Flush recent changes.

Move some functions out of input.c to places where they make more sense.
This makes it easier for me to re-org input.c.

The tabkey.jm script is at least minimally functional now.  If anyone
wants to find more bugs, just let me know.

* Fix output of /disconnect when disconnected to be less confusing.
* Some changes to tabkey.jm to see if we can get it working.
* Move old items from KNOWNBUGS to the epic5 change file.

Rename 'wserv4' to 'epic5-wserv4' to avoid conflicting with epic4.

New tabkey.ce from fudd
New epic!

Only one boneheaded error last night.  Much better than my normal average!

* Add /xecho -t <target> which outputs to a target, for kreca

* Add arg to panic() controlling whether panic is sent via QUIT (rb black)

* Add $serverctl(ALLGROUPS) for kreca

* Fix fulldesc handling code to put []s around ipv6 p-addrs. oops!
* GC the if 0'd decls from before the switch to ServerInfos
* Add $serverctl(GET <refnum> FULLDESC) for kreca.

* Fix warnings found by gcc4 and run make depend.
* Add check for -Wno-pointer-sign to configure; makes using gcc4 less painful.

Fix bug reported by kitambi.

* Fix null deref in set_input() via reset_line() via ^U (rb kitambi)

* Stage 2 -- start eliminating "optimizations", use update_input() for redraw

Stage 1 in a major overhaul of the input line handling code.
Caution -- road may be slippery when wet.  Many more changes to come.

* Fix bugs with 'builtins' (zlonix)
* Revamp the term_init() function, document, etc.
* Unconditionally turn off IEXTEN, IXON, IXOFF, to reclaim all of the chars
  that kernels steal from us (like ^S, ^Q, ^O, ^V, etc)
* Whack the -f/-F/-o/-O command line options; per above.
* I can now bind and use ^S and ^Q and ^V.  Yay!
* Fix initialization of ruby, so it actually works for the first time! YAY!
* Refactor how lastlog is trimmed, by removing a specific item
* Start working on code to remove items from lastlog by grep.
* Fix crashes with /stack push set that kitambi told me about
* Put in a trivial sleep when checking screen size to avoid race with screen.

* Never allow INPUT_PROMPT_LEN to be < 0.
* This fixes the damage from resizing to 1x1 and then back again.

* Don't unconditionally set who_level to NONE in /window.
* Set and reset message_from() info around each /window operation.
* This fixes /window <refnum> echo "<string>" so the line is added to lastlog.
* Fix $ruby(puts 0.4.0) by calling rb_rescue2() to catch /all/ exceptions.
* Fix /window add/query so they auto-remove nicks from other wins first.
* Fix build on non-ipv6 systems. (bruns)

Various and sundry fixes, including allowing you to ignore operwalls.

* Interrogate, and pass upwards, the socket error from getsockopt()
for nonblocking connects, and then output that error to the user.
Requested by twincest.

* Don't auto_whowas channels.
* Remove epicsol email addresses that do not exist any longer.

* Change startup code so it outputs the pid of the bot process for -b.
* Fix $info(o) bug.  rb zlonix
* Output the errno value ret by failed nonblocking server connects on error.
* Add auto-close boolean flag for server (see UPDATES)

* Fix from black for 'save' script, to save notify nicks.
* Fix from larne for configure checks for tcl for solaris (ick)
* Fix solaris ports support, inspired by patch from larne, rb zlonix

Add code to do threaded stdout (from larne)

Fix /stack pop set ...

Add /userhost -extra for nullie

* Make the build work with socks5 again, for freebsd ports support
* Add malloc_strcat3_c().
* Optimize malloc_strcat_word_c

New epic!

Add a very slight delay when receiving the 001 numeric to fix a race condition
that I'm seeing on epicsol. doh. :/

* Normalize $shift() and $unshift() in the same way as $push() and $pop().
* Fix /eval echo $func($*) at the input prompt causing "add is NULL" panic.

* Rewrite $remw() so it uses standard word handling routines.

Add new function $curcmd(), the currently executing command (nullie)

* Change last_arg() so it dequotes the retval according to the word type
* Change $pop() so it only takes an lvalue
* Change $revw() to use the last_arg() improvements
* Improve /xdebug so it takes a block as an argument
* Improve $push() so it pushes the hole argument as dword

Fix the loadformats script.  How did i ever miss this?

* Add support for "conditional dequoting" in universal_next_arg_count
* Change next_earg() and next_func_arg() to use the conditional dequoting.
* This permits me to implement $qword() which returns a $word() literally! yay!

Fix $prefix( ) crash.

Add a new field to server descriptions, 'vhost' to allow you to specify
a per-server virtual host.  All the usual caveats apply.

* Add a WIP document that describes how all functions arglists work.
* Fix a few problematic word manip functions.

* Fix replace_line, it wasn't moving the cursor before writing new contents.
* Fix a double SSL_free, from yesterday's fixes.
* Revamp the "THANKS" file, removing people who contributed to epic4 but
  not (yet) to epic5.  Hopefully this will spur some of them to contribute
  again to be added again. =)

* Fix problem with get_child_exit() can block SIGCHLD.
* Change $mask() so it doesn't require a full $uhc() value, compat with epic4
* Avoid crash by actually removing ssl entries when they're shut down

Fix unexpected problem with 'history' script.
Restore a feature 'history' was depending on that I removed.

This is the start of a major project to normalize the behavior of word
handling in built in functions.  The project involves stipulating that every
place that handles a "word list" define what a "word" is and use it
consistenly, and to output the same type of "words" that it accepts as
input.  This leverages /xdebug dword to control optional support for dwords
in many built in functions.

* Fix cross-matching of ctcp-over-dcc with queries. YAY! (nullie)
* Fix crash when you received ssl-encrypted msgs and you don't have ssl.

Fix some bugs with /window query that kreca found.

* Make $urlencode() rfc3986-ish, converting all non-unreserved chars
* Change ServerInfo to use const char's since we don't modify them directly.
* Reorganize how ServerInfos are used, into "temporary" and "permanent" types
* Convert Server's use of ServerInfo's into safe permanent types.
* Add /server -update <refnum> <desc> to change server descs on the fly.
* Fix typo in /invite.
* Fix 'country' script by wrapping it with xdebug dwords.

* Pass double ptr to remove_bindings_recurse() to fix exit-time memory leak.
* Remove /set bad_style, input_aliases, security,  (unused)
* Remove /set ssl_certfile, ssl_keyfile, and ssl_path (unused)
* Add a (ServerInfo) object to (Server), switch to using it.
* Remove a bunch of unused thingees in (Server) while i'm here.
* Restore /set reverse_status_line to a builtin. oh well.

* Teach history script to use parsekey reset_line (nullie)
* Fix one bogon (still others left!) in map script
* Improvements to 'save' script (blackjac)
* Change /on unknown_command to include // prefix if that was used (nullie)
* Fix behavior of /set old_server_lastlog_level (rb larne, fixed by nullie)

* Fixes for two memory leaks from nullie
* New /on, /ON WINDOW_SERVER, from nullie who needs to write a blurb.

Don't call happykey() on a plain text password.

* MORON.  Don't replace a 'return' with something that doesn't return!

erk.

Add /on unknown_command, from nullie (thanks!)

* Finish implementation of /stack push|pop set with symbol table, rb nullie.
* Preliminary work making @#chan public show up in #chan's window.

Fix bug. doh!

Add /on channel_lost from nullie who needs to write an updates blurb

Add /set reset_line to replace your input line all in one fell swoop
w/o mangling the