CVS log for epic4/source/mail.c

Request diff between arbitrary revisions

* Add support for maildir mail boxes, which must be selected at compile time.

* Numerous updates/changes/fixes to DCC, functions, scripts, /EXEC, the
  new math parser, as per UPDATES and KNOWNBUGS.

One potential incompatibility is in the change to $open(). (as per UPDATES)

Fix it so /set mail 3 and /set mail 4 don't cause panics.

Teach all the /set callbacks to take a (const void *).
This fixes a bad-c problem with /set!

* Add "ON/OFF" toggle set variable to the system timer data.
* Create 'update_system_timer' which uses the "toggle" var to run or stop timer
* Merge '(start|stop)_system_timer' into 'update_system_timer'
* Nix #define MINIMUM_(NOTIFY|CLOCK|MAIL)_INTERVAL since we can't stop that.
* Do not enforce minimums for /SET *_INTERVAL since user could get around it.
* Track "last event" time, maybe I'll use that in the future
* Reset "now" global variable before calling timer callback.
* Fix null deref bug with $($$)
* Add default binding to ^G to "self_insert" for beeps.
* Do not enforce MINIMUM_NOTIFY_INTERVAL in do_notify()
* Don't include exec.h from screen.c
* Add 'number' (floating point) field to /set's
* Add FLOAT_TYPE_VAR type for /set's, using 'number' field
* Update all the /set entries to include a default 'number' field.
* Add get_float_var() to get the 'number' field in a set.
* Add set_float_var() to set the 'number' field in a set.
* Teach set_variable() about FLOAT_TYPE_VAR sets.
* Teach save_variables() about FLOAT_TYPE_VAR sets.
* Teach get_string_variable() about FLOAT_TYPE_VAR sets.

Commit 558
* Don't allow user to /window number in a window with a channel (avoid panic)
* Make check_mail return a (const char *), fix status_mail().
* Modularize/reorganize mail checking, with mbox reference implementation.
* Automatically /set mail 0 if the user's mbox can't be found.

Maybe I fixed a bug, maybe I didn't.

Commit 556
* Change #define DEFAULT_CPU_SAVER_EVERY to 60, it needs not be 0.
* Create 'clock.c', to hold clock generation, system timers, cpu saver watchdog
* Create notion of "sys(tem)timers", callbacks for mail, notify, clock gen.
* Add 'system_timer', generalized callback for all of the system timers.
* Fix add_timer() so the 'command' argument does what the docs say it does.
* Extern 'timer_exists' so we don't try to remove_timer() and invalid timer
* Redo dependancies because clock.h exists.
* Add code to bootstrap mail systimer with /set mail
* Add code to bootstrap clock generation with /set clock
* Add code to bootstrap notify handling with /set notify_interval.
* Start enforcing "NOTIFY_INTERVAL" again in do_notify() to avoid excess flood.

Convert m_strdup() to malloc_strdup().

* Rename 'dcc()' to 'dcc_cmd()' so we can use dcc as variable
* Garbage collect unused 'irc_path' global variable.
* Add --with-warns to configure to do FreeBSD "WARNS" like compiler checks
* Many hundreds of changes to improve the "quality of code" in epic, including:
* - Treat all literal strings as (const char *) and fix const correctness.
* - Mopping up all remaining const-correctness issues
* - Do not "launder" a (const char *) to a (char *) in string searches, (ala
    strchr) but rather return a ssize_t offset value.
* - Particular, MatchingBracket() returns (ssize_t) and not (char *).
* - Eliminate all "shadow" variable names by changing them to something else.
* - Eliminate most function decls that do not include a prototype list.
* - Add prototypes for all extern functions that are missing them.
* - Ensure most function pointers include a prototype list.
* - In term.c, most of those (char *)'s are really (const char *)'s.
* - Explicitly specify 'static' functions as 'static'
* - Ensure every function is either 'static' or has a prototype.
* - Eliminate (unsigned) < (signed) type comparisons.
* Hopefully you should not notice any changes!

Nominally remove all uses of "unsafe" functions: (Commit 506)
* Convert all uses of strcpy() to strlcpy()
* Convert all uses of strcat() to strlcat()
* Convert all uses of strmcpy() to strlcpy()
* Convert all uses of strmcat() to strlcat()
* Convert all uses of sprintf() to snprintf()
* As much as possible, use 'sizeof var' in snprintf/strlcpy/strlcat.
* Qualify the size of some global vars so we can sizeof() them.
* Nuke strmcpy(), strmcat(), strmcat_ue(), strmccat(),
* Change strmopencat() to strlopencat().
* Change strmpcat() to strlpcat().
* Fix switch_hostname so it doesn't return a (const) string.
* Fix TimerTimeout so it doesn't return a (const) Timeval.
* Change things like (ret) to do ret while (0); for when "ret" is "{}".
* Fix initialization for load_level
* Stop passing in static strings into io(), so we can modify them.
* Make messages passed to io() more informative to the user.
* Fix CTCP FINGER handler not to assume (struct pw) strings can be overwritten.
* Use (socklen_t) and not an (int) for socket sizes.
* Don't return a value in a void function...
* Don't use return value of process_dcc_chat_ctcps() for assignment.
* Don't put semicolons after function bodies
* Fix $getopt() to save 'input_size' so we can use it with strl*().
* Convert all uses of stpcpy() to strlcat() and strlopencat().
* Nix checks for stpcpy() in configure -- regen configure.

Another merge.

Yikes.  Merged to become consistent with HEAD.  Sorry for all the commits,
I'll be quiet again soon. :)
-wd

* Use server_list_size() and not number_of_servers outside of server.c
* Use NOSERV and not -1 for "no server"
* Use (Timeval) and not (struct timeval)
* Fix (get|set)_server_sent_*() et al to take server refnum.
* Use parse_server_index() and not my_atol() to parse server refnums
* re-indent quotecmd
* Rename is_server_connected() to is_server_registered
* Make /quote work as long as server is open (not registered)
* Use send_to_aserver() when it can avoid setting from_server unecessarily
* Change sent_to_server and clear_sent_to_server to (set|get)server_sent().
* Change doing_* to get_server_doing_*.
* Use (unsigned short) and not (u_short)
* Use (unsigned long) and not (u_long)
* Make output_reject_ctcp() take a refnum
* Lock a dcc while we are connecting it, just in case. ;-)
* Fix /dcc send -p <port>
* Store protocol enforcements as (get|set)_server_protocol_state().
* Use (Stat) and not (struct stat)
* Rewrite $timerctl() so it works like $logctl()
* Rename is_server_connected() to is_server_registered()
* Fix an off-by-one error with /FOR ... IN ...
* Keep track of both readable and writable fd's with newio stuff.
* Convert server_list to an array of pointers
* When user /server -delete's, leave a gap, don't change refnums around.
* Nix code that handles deleting server refnums.
* New function, new_open_for_writing(), for when we do nonblocking connects.
* Change new_open() to deregister fd as "writable"
* Renovate the notify stuff to take refnums and not just use from_server.
* Renovate /WHO, /ISON, /USERHOST to take refnums and not just use from_server.
* Make everything that uses server_list[] use get_server() instead.
* Make everything capable of dealing with "gaps" in server_list[].
* Use a bunch of macros, to handle with getting and setting server attrs.
* Make as much as possible use refnums as params and not from_server.
* And a lot of other stuff...

* Change expand_twiddle(), path_search() to take results as params, int retval
* Add normalize_filename(), to do job expand_twiddle() used to do.
* Add isdir(), just because
* Change /CD, /LOAD, /SAVE, /DCC SEND, /DCC GET, to use normalize_filename.
* Change /DCC RESUME, $open(), $which(), $unlink() to use normalize_filename.
* Change $rename(), $rmdir(), $fexist(), $fsize() to use normalize_filename.
* Change $glob(), $globi(), $mkdir(), $chmod() to use normalize_filename.
* Change $ftime(), $randread(), and uzfopen() to use normalize_filename.
* Change /LOG, /SET LOGFILE, servers file to use normalize_filename.
* Fix /LOG so maximum number of targets per log is a compile time #define.
* Revamp expand_twiddle() and uzfopen().
* Fix uzfopen() to look for 'bunzip2' in addition to 'bunzip'.
* Fix bug with /QUEUE -delete
* Remove unused variable in window_scroll().

Update copyright notices and copyright dates.

Initial import into CVS

Initial revision