CVS log for epic4/source/hook.c

Request diff between arbitrary revisions

* Add /on signal (pegasus)
* Fix /set indent if /set continued_line contains ^C stuff (pegasus)

Last material change to epic4! (hopefully -- cross fingers)
* Fix wording of default messages for 347 and 349 numerics.
* Fix column alignment for /timer list.
* Fix add_to_window() to stop runaway recursion through /set output_rewrite.
* Fix bug in expand_alias() -- all output must be privileged_yell()!
* Change /on send_to_server so it can't be hooked recursively.

* Add /ON WINDOW_BEFOREKILL
* Another iteration of the 'notify' script, hooks the system's /ONs now! =)
* Put a space in place of a newline in the PF loader.
* Always ignore spaces after semicolons in parse_line (the {} parser).
* Some compiler warning fixes from rain.

(*gulp*) Some changes for fudd.
* Add /ON WINDOW_COMMAND, hooked after every /window command, $* is refnum.
* Add concept of "fixed" or "frozen" windows when you SKIP ON FIXED ON
* Fix /window kill to not kill the last "non-fixed" window
* Fix /window hide to not hide the last "non-fixed" window
* Allow /window kill to kill a "fixed" window, but not the last window.
* (*gulp*) I hope all of the above works!
* Fix $windowctl(REFNUM ...) it was out of order with REFNUMS
* Make /xecho -l override the "who_from" target and always send to the level

Implement infinite recursion detector and thwarter.  It requires a #define
in config.h, the future of which I have not decided yet.

Add /on dcc_activity, a hook for scripters to create a %D-workalike.

Commit 551 -- second to last commit for this project -- the big one!
* Roll in the new universal_next_arg_count() and attendant macros.
* Comment out some deprecated function decls in ircaux.h
* Do another round of make depends.
* Modify alias arglist code to use the new universal_next_arg_count() stuff
* Convert dequote() to dequoter().
* Convert new_new_next_arg() into new_new_next_arg_count().
* Comment out deprecated functions in ircaux.c -- will be deleted later.

Commit 548
* Nix channel_window, duplicate of get_winref_by_channame()
* Make arglist processor panic if it sees an argtype that doesn't exist.
* Fix bug with * operator in exprs like (a ? b : *c) in new expression parser.
* Fix theoretical crash with deleting hooks from /on window. Bleh.
* General cleanups in if.c.
* Fix /timer -list acting all wacky.
* Fix compilation warnings, you know the deal...

* Convert parse_line_with_return() to call_lambda_function().

Convert m_strdup() to malloc_strdup().

* Rename 'dcc()' to 'dcc_cmd()' so we can use dcc as variable
* Garbage collect unused 'irc_path' global variable.
* Add --with-warns to configure to do FreeBSD "WARNS" like compiler checks
* Many hundreds of changes to improve the "quality of code" in epic, including:
* - Treat all literal strings as (const char *) and fix const correctness.
* - Mopping up all remaining const-correctness issues
* - Do not "launder" a (const char *) to a (char *) in string searches, (ala
    strchr) but rather return a ssize_t offset value.
* - Particular, MatchingBracket() returns (ssize_t) and not (char *).
* - Eliminate all "shadow" variable names by changing them to something else.
* - Eliminate most function decls that do not include a prototype list.
* - Add prototypes for all extern functions that are missing them.
* - Ensure most function pointers include a prototype list.
* - In term.c, most of those (char *)'s are really (const char *)'s.
* - Explicitly specify 'static' functions as 'static'
* - Ensure every function is either 'static' or has a prototype.
* - Eliminate (unsigned) < (signed) type comparisons.
* Hopefully you should not notice any changes!

Nominally remove all uses of "unsafe" functions: (Commit 506)
* Convert all uses of strcpy() to strlcpy()
* Convert all uses of strcat() to strlcat()
* Convert all uses of strmcpy() to strlcpy()
* Convert all uses of strmcat() to strlcat()
* Convert all uses of sprintf() to snprintf()
* As much as possible, use 'sizeof var' in snprintf/strlcpy/strlcat.
* Qualify the size of some global vars so we can sizeof() them.
* Nuke strmcpy(), strmcat(), strmcat_ue(), strmccat(),
* Change strmopencat() to strlopencat().
* Change strmpcat() to strlpcat().
* Fix switch_hostname so it doesn't return a (const) string.
* Fix TimerTimeout so it doesn't return a (const) Timeval.
* Change things like (ret) to do ret while (0); for when "ret" is "{}".
* Fix initialization for load_level
* Stop passing in static strings into io(), so we can modify them.
* Make messages passed to io() more informative to the user.
* Fix CTCP FINGER handler not to assume (struct pw) strings can be overwritten.
* Use (socklen_t) and not an (int) for socket sizes.
* Don't return a value in a void function...
* Don't use return value of process_dcc_chat_ctcps() for assignment.
* Don't put semicolons after function bodies
* Fix $getopt() to save 'input_size' so we can use it with strl*().
* Convert all uses of stpcpy() to strlcat() and strlopencat().
* Nix checks for stpcpy() in configure -- regen configure.

A lot more cleanup.  Namespace scope changing within aliases now works.
-wd

Okay.  User input is now handled specially, and parse_command() will not
accept incomplete command names anymore.
-wd

Another merge.

Yikes.  Merged to become consistent with HEAD.  Sorry for all the commits,
I'll be quiet again soon. :)
-wd

Commit 443
* Uniformly use 32 bit file sizes in dcc.  That's the way it has to be.
* Split process_incoming_chat into modular functions.  It's an experiment.
* Remove the old, #if 0'd dcc_getfile_resume.
* Remove the second, redundant warning from /window refnum(_or_swap).
* Make the ArgList portion of server messages const.  All const!  Huzzah!
* Roll /names, /list, and /mode numeric handlers into numbers.c
* Roll "funny" global variables into server-specific variables
* Nuke funny.c and funny.h -- huzzah!
* /on window_kill provides two args now, $0 is refnum, $1 is name/refnum.
* Rename "numeric_banner" to "banner"
* Rename "parse_notice" to "p_notice"
* In /xecho, rename 'banner' local var to 'want_banner'.
* Revamp p_notice to look like and act like p_privmsg as much as possible.
* Finish the rest of the larnifications.  Done with phase 1.  Huzzah!

Commit 436
This commit is deceptive because it is huge in scope but can be explained
pretty simply.

* Const correctness improvements.
* Invert the meaning of 'new_check_flooding' to return TRUE if flooding.
* Revamp funny.c, /list, /names, /mode reply handling.
* Remove unused joined_nick, public_nick
* Change got_initial_version_28() arguments singly and not an array
* Change signature of protocol handling to take "command" as an argument
* The above change cascades to a lot of other changes.
* Allow the /msg'ing of @W<refnum> to msg a window's refnum.
* First round of larnification (Protection against unexpected server data)
* This involved substantial rewrites of parse.c, and numbers.c
* Now "fake" stuff goes through /on odd_server_stuff.
* Fix /on invite so it takes 3 arguments, not 2.

* Add $getserial() function.
* Add +|- special serial handlers to /on
-wd

Update copyright notices and copyright dates.

No functional changes, just removal of unecessary whitespace at the end
of lines.  From adm.

* Rolled the $getsets() and $getcommands() code into macros and added
  $getfunctions().
* Added a server_established hook.  This is called before anything is sent
  to the server, and it is intended that for ssl connections, stuff can be
  quoted and hooked in plain text until the hook returns, although, it is
  difficult to verify that this will actually work.
* Made it so that when all variables are erased, the low level array that
  contains the variables is erased.  This is intended to make it easier to
  profile the memory use.
* Copyright notice added to perl.c.
* Minor stuff for tabkey.ce.

Applied the SSL patch from ay-ar.

Details are in README.SSL.  This works well at this point, but there may
be teething problems.

Fixed a bunch of memory leaks:

* In /alias with no args, one leak for each line printed.
* If an /on would clober another /on, there would be a leak.
* In "/timer -ref xxx", if xxx existed and therefore blocked the timer,
  there would be a leak.
* "/server -d" wouldn't erase the notify list and one or two other things
  for the server
* And the last one I am _not_ sure about.  prepare_display() had a leak,
  however, this does appear to be a work in progress, and the pointer
  in question points to a strange combination of static, dynamic and
  alloca() variables.  I made the smallest possible patch which seems
  to work, however, its quality may be questionable.

I put GENERAL_PRIVMSG in the hook.c list twice.  Broke everything.
Removed.

Ok.  ESR asked us to change our manpage.  Some of his changes worked,
some of them did not.  I took the ones that did work.

Add /on general_notice and /on general_privmsg.  These will be documented
in UPDATES -- they are generalized versions of /on (msg*|public*) and
/on (notice|server_notice).

Break backwards compatability on /on ctcp_reply by changing $*
	$0	Sender
	$1	Target		[new]
	$2	CTCP command	[Was $1]
	$3-	CTCP Arguments	[Was $2-]
Everyone i asked wanted this change, so i claim immunity.

The value returned by parse_command_with_return in do_hook is malloced
and needs to be freed.  Rearranged the code a little to make this clean.

Revert the previous change -- this is a bad time to experiment.

/on topic throws three arguments, not two; fix the numargs value for
/on topic in hook.c

Commit #29:
* Add /on error, to handle ERROR protocol messages.
* Fix /window * toggle, to actually toggle.
* Add /defer command, per email on epic list.
* New hybrid6 script from is-.
* Fix a bug with strlcat() from openbsd via freebsd.
* Axe long broken "1 second cursor in window" delay thing.
* Repeal the "deferred free" stuff in 0.9.15-10 that wasn't too good.
That's it!

Initial import into CVS

Initial revision