CVS log for epic4/KNOWNBUGS

Request diff between arbitrary revisions

New epic!

* Fix brain-o -- AC_MSG_RESULT is not the same as AC_DEFINE, dummy.
* Add $regcomp_cs() from epic5 as a special favor to blackjac.

* Right about now Kev is wondering what is going on, that I'm making
  all these changes to epic4 after so many years of just bug fixes.
* Resolve build conflicts between x/open curses and ncurses. ugh.

* Move "term.h" out of the way so we can #include <term.h> (mv'd to termx.h)
* This makes it possible to avoid empty decls for tparm()
* Which is supposed to fix the build for larne on who-only-knows-what.
* Rename tparm() to my_tparm().
* Do a make depend since i changed the name of a header file. ugh.
* Change the name of (struct term) to (struct my_term) for freebsd sake. ugh.

* More changes for larne's cross-building project.

* sig.inc should be created in the include directory. (rb larne)
* Fix build on systems where CFLAGS doesn't get set (larne)

* Patch from larne to fix build on interix

* Add /on signal (pegasus)
* Fix /set indent if /set continued_line contains ^C stuff (pegasus)

Fix the build on systems without intmax_t/strtoimax().

* New version of /load hold_mode (implements /set hold_interval)
* Fix crash with $write(w<number> text)

* I made an oopsie. $tobase() should *now* support negative integers!

* Backported functions $strtol() and $tobase() from EPIC5. Request from
  |Rain|. See UPDATES for more information.

* Fix brain-o in a previous fix.

* Add $windowctl(GET <refnum> CHANNELS) in kindness to BlackJac.

* Fix crash for /parsekey type_text

Add support for +T by special request.

* Fix inability to /query an /exec'd process.

New EPIC!

* Fix crash with $xdebug() with no arguments.

Make the build work with socks5 again, for freebsd ports support.

* Add a missing cast for printf when sending a dcc handshake.
* Support isfinite() for hpux/c99 alongside finite() for bsd.
* Fix bug where SIGCHLD can be blocked and never unblocked.

* Add support for maildir mail boxes, which must be selected at compile time.

Fix crash when doing /nick <unique id> on ircnet.

Fix more larnification bugs found by ircfuzz.  All clear now, really! ;-)

Fix crash revealed by ircfuzz.  Thanks go to the anonymous person who
pointed this out.  Only one bug found by ircfuzz! ;-)

* Fix two 64-bit pointer errors (one in dcc.c, and one in who.c)
* Fix refresh_a_screen() to not pass NULL to recalculate_windows().
	(reported by cshepherd, thanks!)

Fix output from exec to go to the correct server (the 'if' here is
guarding the wrong assignment!)

* Fix error messages when you /exec -direct asdf, from epic5.
* Add more gracious support for unique id's and nickname 0, from epic5.

Fix /while et al not to do LOCAL_COPY within infinite loop, from epic5.

* Fix 'get_local_server_port', add $serverctl(GET * LOCALPORT). (fudd)

Fix problems with log refnum -1 in /set log_rewrite.

* Fix translation for zlonix
* Fix /ignore for larne

Roll off old docs, just a little bit of housecleaning.

* Fix 353 numeric so channels w/o users on ratbox aren't "odd"

Fix /window <refnum> scroll_forward/scroll_backward, for blackjac

Fix /away -all

* Fix null deref when you do /window flush while not in hold mode.

Fix end-of-invite/except list for braino.

Last material change to epic4! (hopefully -- cross fingers)
* Fix wording of default messages for 347 and 349 numerics.
* Fix column alignment for /timer list.
* Fix add_to_window() to stop runaway recursion through /set output_rewrite.
* Fix bug in expand_alias() -- all output must be privileged_yell()!
* Change /on send_to_server so it can't be hooked recursively.

* Fix space-related panic.  See UPDATES for all the gruesome details.
* Add ALT_CHAR to the list of things that can be mangled.

Fix brain-damage

Change the mangler so ANSI turns off ALL_OFF unless all six attributes
are being stripped.

Just update a bug i forgot to mention i fixed.

Fix $logctl().

* Fix color bleeding with color changes in middle of long words that wrap.
-- This was reported by blackjac.  It's a bug that occurs if you do a color
change in a very long word that ends up wrapping to the next line.  If there
are no more attribute changes ni the next line that it wraps to, then the
line after *that* (the third line) will get the attributes at the end of the
1st line instead of the attributes at the end of the 2nd line.

* Fix compile warning for alloca on freebsd-current for blackjac. bleh.

* Fix compile error with password protection
* Make symbolic link from 'epic' use a relative path.

* Add %{2}W and %{3}W from epic5 (for blackjac)
* Fix $stripcrap(ALL,-<type> ...) from epic5.
* Add support for +e and +I numeric replies for efnet.

* Avoid NULL deref on brok^H^H^H^Hempty numeric replies

* Increase buffer for %F (and %{1}F) from 80 bytes to 2k.

* Allow /userhost <uniqueid> for ircnet.
* Allow 'epic 0 <servername' for ircnet.

* Implement "unique id" support for ircnet (042 numeric)
* You can /nick 0 or /nick <unique_id>
* You can use $servertctl([SET|GET] <refnum> UNIQUE_ID)

Flush all of the small bug fixes i've been sitting on.

This should NOT have been commited.  Back it out.

Add /xecho -f for howl
Add a timer dump for "stuck in a polling loop!"

Fix many errors using realpath() and normalize_filename().

Fix my_realpath() for linux users.

THE LAST CHANGE -- I REALLY MEAN IT THIS TIME.

EPIC4-2.0 passes its vote of confidence!
* Fix a bug with /window channel frobnitz hide doing a null deref
* NSX asked for one more change under the wire.

The nick list in 353 is not mandatory.  IE:
	:server.name 353 mynick = #chan\r\n
is perfectly acceptable.

Fix bug with history expansion when there is a line with only /'s in it.
Reported and fixed by |Rain|.

Fix $-at-end-of-string null deref (/echo $($))

Try to fix %\\ and *\\ for zinx's official objection.
I hope i hope i hope i hope i didn't break anything else....

* Fix /WHO arg handling.  The old code was crap and wouldn't do /who -oper

New script, 'urlgrab' from wc.  Thanks!

Script changes from howl and nsx, as requested.

Fixes and new features as per KNOWNBUGS and UPDATES.

* Fix bug with nicks ending with \ in the 353 numeric which has trailing space
* Auto-close DCC's that can't send handshakes due to family mismatch.

Miscelaneous fixes and features as per UPDATES and KNOWNBUGS.

* Fixed $shuffle*() to respect extractw.
* Altered $rest() so that a negative first argument makes it a compliment to
  $right() in the same way that a positive arg makes it a compliment to
  $left().  This may conceivably cause problems for scripts.
* Spruced $joinstr() up a bit.  It now accepts any number of variables and
  respects extractw.
* Fixed an extractw bug in malloc_strcat_word_c while testing the above.

* Added $splicec() in functions script.
* Added /set dcc_dequote_filenames.  Perhaps this should default to off?

Allow semicolons in the middle of the switch command.

Change default of /SET AUTO_REJOIN to OFF.

Fix for meta-compat, from rain.

* Make inet_vhostsockaddr() extern so dcc can use it
* Make dcc_open() use inet_vhostsockaddr() to bind /hostname to dcc conns
* Don't allow -b and -q, or -b -and -s, as they cause deadlocks/panics
* Fix casting error that caused $urlencode() of high bit chars to segfault
* If swapping in a window that has no room for double status, recalculate all
* If double-on in a window that has no room for it, recalculate all

* Fixes to 'less' script from howl
* New 'help' script from howl
* Add /WINDOW SCROLLADJ.

Fix some more problems in the pf loader.

* Add /ON WINDOW_BEFOREKILL
* Another iteration of the 'notify' script, hooks the system's /ONs now! =)
* Put a space in place of a newline in the PF loader.
* Always ignore spaces after semicolons in parse_line (the {} parser).
* Some compiler warning fixes from rain.

* Do not increment arg_count when ignoring an empty argument in arglists.

* Make the output-window-searcher ignore from_server for LOG_DCC
* Make status_hold and status_hold_lines use scrollback numbers too.
* Make add_to_scrollback() redraw status bar if output while scrollbacking.

* Fix DCC events so that they occur in the context of "no server" (FROMSERV)
  rather than the "current server" (NOSERV).  This can fix or completely break
  certain intermittent scripting problems.
* Fixed {f,}q1cmd in commandqueues so that it works properly in the "no server"
  context.

Fix some issues with $numlines()

* The last argument to open_file_for_write() needs to be lowercase.
* Add $numlines() from fudd.
EPIC4-1.2.3!

* Fix /window kill so it doesn't swap in a window too early.
* Make NOTICEs from servers to channels (on ircnet) go to that channel's win.
EPIC4-1.2.2!

* Fix /window next, /window prev (SWAP_NEXT_WINDOW/SWAP_PREV_WINDOW) to
  skip non-swappable windows.

* Add /SET STATUS_NOSWAP
* Fix #define DEBUG_EXTRACTW_DEBUG/LASTLOG
* Add -o and -O command line options to turn off IEXTEN termio() options
* Add /WINDOW SWAPPABLE (defaults to on)
* Add %{1}W status expando, expands to /SET STATUS_NOSWAP if SWAPPABLE OFF
* Don't allow windows to be swapped in or out if SWAPPABLE OFF
* Don't allow windows to be shown or hidden if SWAPPABLE OFF
* Do allow windows to be swapped in with WINDOW KILL even if SWAPPABLE OFF
* Add $windowctl(GET <refnum> SWAPPABLE)

More compiler nits fixed.  Nothing worth fretting over.

* Fix a couple of minor compiler nits
EPIC4-1.2.1!

* Fix a NULL deref if you do /window when there is no current window (!)
* Update notify script from nsx, add sping script from nsx.

* Fix the larneproofing in numeric_handler(), it was defective all over.
-- Reported by jb.

* Update tabkey.jm one last time
* Add 'notify' script, a replacement for the notify command.
* Fix $windowctl(GET <refnum> DOUBLE)
* Make /on window_command give two refnums, the before and after refnums.

* Add $windowctl(GET <refnum> DOUBLE)
* Support inbound double quoted filenames in dcc handshakes. bleh.
* Fix NULL deref when you kill hidden windows (ie, /window killswap)

* Fix raw listen DCCs not obey /SET DCC_TIMEOUT.
* Added outputting of long long ints to new math parser.

(*gulp*) Some changes for fudd.
* Add /ON WINDOW_COMMAND, hooked after every /window command, $* is refnum.
* Add concept of "fixed" or "frozen" windows when you SKIP ON FIXED ON
* Fix /window kill to not kill the last "non-fixed" window
* Fix /window hide to not hide the last "non-fixed" window
* Allow /window kill to kill a "fixed" window, but not the last window.
* (*gulp*) I hope all of the above works!
* Fix $windowctl(REFNUM ...) it was out of order with REFNUMS
* Make /xecho -l override the "who_from" target and always send to the level

Document $windowctl().

* Fix /lastlog <number> for kanan.

More complicated atoll() replacements.

Unconditionally do (long long) integer math in the new math parser if
your system supports (long long).  I suppose on some systems this will
make math slower, but that seems like a small price to pay for having
integers that will actually support IP addresses!

$info(o) will inclue the letter 'l' if the host client is working with
64 bit integers in the new math parser.

Please note that the old math parser has not changed, and still only
supports 32 bit integers, and that won't change for backwards compatability.
If you really really really need 64 bit integers, think about changing to
the new math parser.

Changes agreed to in principle by: ce
* Make /server <host> honor server groups if can't connect to <host>
* Make reconnects use the server group of NEW server not OLD server.

Fix typo that broke /notify on servers other than server refnum 0.
Broken in commit 403 (Dec 19, 2002).

Fix typo after i told nsx the bug couldn't possibly be becuase of a typo.
(nsx found the way to reproduce the bug so he did all the hard work here)

* Fix /window query, it was a victim of larneproofing.  Ooops! (Bugref 6)
* Hook in $windowctl(), just for fun for now.
* Enclose a few more dcc outputs in the target nick context.

* Fix a possible logic hole in ok_to_output()
* Fix memory leaks found by valgrind.

* current_window_priority should be global variable
* Valgrind is my hero -- fix buffer underruns with mangle_line().
* Make the "current input window" its server's current window on user input.

Implement infinite recursion detector and thwarter.  It requires a #define
in config.h, the future of which I have not decided yet.

EPIC4-1.1.15!

From previous commit...
* Fix urldecode
* /lastlog -msgs 3 is obliged to skip back 3 msgs, not just 3 lastlog entries.
* Fix warnings in gailib.h

From this commit...
* Fix some const correctness issues
* Make message_to() take an (int) and not (unsigned) so we can pass in -1.
* Fix some arglist regression tests to reflect new extractw semantics.
* Fix uninitialized variable in ok_to_output() that caused panics.

See KNOWNBUGS

* Fix panic with $joinstr()
* Fix compiler warning comparing pointer against integer
* Fix word appender to NOT USE DOUBLE QUOTES if /xdebug extractw is off!
* Fix the word appender so it actually works right.

* Numerous updates/changes/fixes to DCC, functions, scripts, /EXEC, the
  new math parser, as per UPDATES and KNOWNBUGS.

One potential incompatibility is in the change to $open(). (as per UPDATES)

Add /who -operspy for hybrid opers.

Add sanity checking to avoid cross-family dcc problems, where we bind() a
listening socket in one family and send out a dcc handshake for another
family.  Oops!  Noticed by rain.

Add /on dcc_activity, a hook for scripters to create a %D-workalike.

* Add /set wserv_type, either "xterm" or "screen".
* Add malloc_strcat_word_c, add a single word to word list, with "" support
* Convert a bunch of stuff to use malloc_strcat_word_c to honor ""s right.
* GC a bunch of unused code.

Commit 610:
* Use the server's message in our default 330 output.
* Make $numwords() use count_words() as a test.  Looks ok so far...
* Make $indextoword() use count_words().
* Implement regression tests for $indextoword()
* Any further problems with $indextoword() should add regress tests!
* Make epic behave like ircII when doing /window create with screen and X.
* Make move_to_next_word() stop when it hits a trailing nul, duh!

* Work around "(brown paper bag release)" version in 004 in ratbox-1.2-3

RFC1459 says that protocol commansd have 15 arguments *in addition to*
the command.  Fix an off by one error.

* Allow $serverctl(SET <refnum> UMODES)

EPIC4-1.1.13!

Commit 600 -- Huzzah!
* New tabkey.jm script from nsx.
* Set the window's waiting channel before sending out the JOIN
* Let <pagedown> and <end> work on hold mode as well as scrollback.

Make sure message_from() gets called properly before a /dcc chat message.

Fix UNSTOP_ALL_WINDOWS keybinding, rb ce.

Implement "privleged yells" which allow syou to do /set debug 7 at the
same time as /set output_rewrite.  Yea~!

* Add $servernick(<global>) to return the client's global nickname
* Update tabkey.jm to latest version
* Add new ircII-compatable /window hold_mode thingee.
* Add /set hold_slider, /window hold_slider
* Add 'hold_mode' script, implements ircII-like /set hold_mode[_interval]
* /XEVAL -- ends eval option processing, like how /xecho does it.

Fix $servernick()

Fix /set mangle_inbound

Add $servernick(<global>) which returns the client's global current nickname.

Fix the {...} expression parser operator to not infinite loop when it
can't find the $FUNCTION_RETURN local variable.  Umm, yea.

Fix panic caused by accidentally allowing the user to /server -delete all
their servers. (fix is to not allow them to delete the last server)

Fix it so /set mail 3 and /set mail 4 don't cause panics.

Nominally allow someone to do:
	/dcc rename <nick> <file> <absolute path>
for example:
	/dcc rename hop alias.c /usr/home/jnelson/foo/alias.c
which acts as a "per-dcc" store path.  Normally files are stored in your
/set dcc_store_path unless you /dcc rename them to another absolute path.

I do not know if I broke anything doing this.  Let me know if you see
anything odd.

Make ^ and ~ equivalent since all irc servers do already...

* Fix /on ctcp_reply so it hooks in the LOG_CTCP context. (rb nsx)

* Make /window swap update the current-window-priority thingee.

* Revert all uses of LOG_CURRENT to LOG_CRAP
* Change all uses of message_to(0) to message_to(-1)
* Fix show_help() to not change to_window, it doesn't need to care about that.
* Fix help_put_it() to not change message_from, doesn't need to care about it.
* Fix /lastlog to use message_to(0) to send all output to current window.
* Don't make output of /log go to current window -- no point to that.
* Teach add_to_screen() to honor from_server's current window for LOG_CURRENT
* And for /set current_window_level as well
* Fix message_from() not to save/restore lastlog level, doesn't need to care.
* All of this pretty much nukes LOG_CURRENT except for /window, HUZZAH!

Fix panic for $push(:foo )

Commit 581
* Fix /dcc chat nick -p 4444
* Return empty string if you do $aliasctl(pmatch <bogus> <whatever>)
* Update some copyright notices.

* Fix buffer overrun crash with CTCP UTC.

* New script features, cleanups, docs, etc as per KNOWNBUGS and UPDATES.

Include <stdint.h> and <inttypes.h> if they exist.

Fix bug 5 -- panic when you do $push(:foo   ) [and $unshift() too]

Make some compile warnings go away by using (intptr_t).  I hope this
doesn't bite me -- every system I checked has (intptr_t)..

Add nsx's 'tabkey.jm' script.

Fix a really stupid bug I made last night.  :/

* Fix $<num> to not have leading or trailing spaces, cause zinx said so. ;-)

Fix some bugs that can be attributed solely to a total lack of testing
on my part.  I'm rather embarrased about this.

Teach all the /set callbacks to take a (const void *).
This fixes a bad-c problem with /set!